[Closed] my messy code

running code on selected objects is generally slow. convert your selection to an array, and iterate that.

  
   local objList = $selection as array
  clearSelection()
  
  for o in objList do
  (
  ....
  )
 

you dont need that for t=0 to 1 either, unless thats doing something i’m missing.

also you’re doing 2 checks in one. instead of caching a true/false value, and then comparing it. Just one line it.

So instead of…

   er1= classof o.pos.x_position.controller ==  float_wire --- returns true
    if er1==true then animationonscene=1
   

Do

   if ClassOf  o.pos.x_position.controller ==  float_wire then animationonscene=1
   

there are many ways of cleaning this up, but that’s a start.

thanks,
I wrote simple code from elements which was given to me to test it.
I selected couple of geometry objects and fire up your code and there were error raporting in listner immediately after code is start:

– Error occurred in anonymous codeblock; filename: E:\WORK\doctor\visual 1.ms; position: 14; line: 1
– Compile error: no local declarations at top level: objlist
– In line: local objList =

local objList = $selection as array
clearSelection()

for o in objList do
(
if ClassOf o.pos.x_position.controller == float_wire then animationonscene=1
)

I also tried with local objList = $selection as array instead local objList = $selection as array and don’t work to. How to fix it?

that error means you are trying to declare a variable in at the top level. All of your code should be within parenthesis. This is good practice in general, otherwise anything you write is ‘global’, which could have several undesired results.

So your code should look like

 
    (
     	
     local  objList = $selection as array
       clearSelection()
       
       for o in objList do
       (
          if ClassOf  o.pos.x_position.controller ==  float_wire then animationonscene=1
    ....
       )
    
    )
     

This code behave strange. I created box with
.pos.x_position.controller == float_list

• another two objects with standard controllers.

and play with your code:
(
animationonscene==1
local objList = $selection as array
clearSelection()

   for o in objList do
   (
      if ClassOf  o.pos.x_position.controller ==  float_list then animationonscene=1

— …
)

)
if animationonscene==1 then messagebox "sssssss"

when I fire it up on object with float_list controller for the first time script wont work properly but next time was ok, so I repeated for next objects and first time was failed then ok,
for next object this same. So it hard to say it work or not :surprised Anyway I wondering how can I do such a code for my future projects referred to my initial problem:

list_of_items=“meshsmooth,skin,skew,uvwmap…etc…”
check modyfier list in selected objects if any of them meth list_of items do…

or
A=“aa”
list_of_items=“aa,ab,ac,ad…etc”
check if my variable A= list_of_items do …

your first line is actually a compare, not a declaration

 
   animationonscene==1	
   

is actually asking “is animationonscene equivalent to 1”, which will be false in this regard as animationonscene is undeclared and will be ‘undefined’

it should be

  animationonscene = 1
  

if thats what you are trying to do.

   if animationonscene==1 then messagebox "sssssss"
   

should be inside the ( )

The reason it doesnt work, is because you are declaring ‘animationonscene’ inside the ( ), where it should be…but you are asking for its value outside of the ( )…so it has no idea what ‘animationonscene’ is.

all code should be inside the parenthesis.

( – should be at start of file

) – should be at end of file.

If you put it inside the ( ), and fix your first line, it should fix those errors.

I’m not sure what the second half of your post is asking. what are you trying to accomplish?

find controllers by class is fast and easy:

(
	delete objects
	for k=1 to 1000 do dummy name:(k as string)
	gc()

	cc = for c in FloatController.classes where c.creatable collect c 
	for c in getclassinstances Bezier_Float do replaceinstances c (createinstance cc[random 1 cc.count])
)
for c in cc do
(
	format ">> %
" c  
	nodes = #()
	t1 = timestamp()
	for i in (ii = getclassinstances c) where (node = refs.dependentnodes i firstonly:on) != undefined do appendifunique nodes node
	format "	nodes:% controllers:% search time:%
" nodes.count ii.count ((timestamp()-t1)/1000.0)
)

In this case it isnt really an issue, but as it seems he is new to maxscript, i was referring to the general practice. Basically when doing any commands that might make the mod panel refresh. it seems faster to do the commands without anything selected…or to be in create mode. As is my experience anyways.

everything said above is true. but it doesn’t mean that the iterating through selected objects is slower than iterating through unselected.

Nice code for making 5000 boxes Denis, I fired it up and it blow my computer memory up so I write this again.Hobbs
You are right. For me Denis code is a black magic, I think he is guru, he see blode hot girls in red dressed and I see only numbers and letters, exclamation and question marks:) You both explan me a lot but I need Hobbs level of approach.
No I’m pretty confused because now my code base on selecting and deselecting object on scene but Denis maintain it’s no different between operation on selection and arrays and Hobbs Claim oposite. Denis code crash my computer, who’s right gentlemen?

Anyway operating on selection list (arrays) give me ability I need for some of my functions.

I have two problems I have to solve it before I start:

CASE 1) HOW TO REMOVE ELEMENT(S)(in this case object(s)) FROM LIST,

below I submit my code.Example: I want get all objects and put it to list then remove t objects from my list(t=geometry, it’s important that t must be variable)
and then select objects in my selection(without geometry) :

select objects
myArray = #()
—- collect all object on scene
for o in selection do
(
append myArray o
)
clearSelection()
sleep 2
— remove from collection geometry objects
select geometry
for t in selection do
(
deleteitem myArray t
)
clear
select myArray
— end of code

It seems like deleteitem myArray cause error:
– Error occurred in t loop; filename: E:\WORK\doctor\patents\operating on list of elements\adding to list.ms; position: 250; line: 14
– Frame:
– t: $Torus001
– Runtime error: array index must be positive number, got: $Torus:Torus001 @ [50.070679,-15.374176,0.000000]

CASE 2) HOW TO COMPARE ELEMENTS(in this case controller(s)) FROM LIST WITH EXISTING,

Second example it’s pretty much self explanatory, so my code is:

—- script search for controllers from mycontrollerlist
select geometry
mycontrollerlist=#(Position_XYZ,audioposition,attachment)
for o in selection do (
if clasacontrolerB=classof o.position.controller == mycontrollerlist then messagebox “I found my controllers”
)

But it won’t work.