[Closed] C++ ReplaceVertexWeight

we have already shown you in other posts that this is not right…

you should decide what to use ISkin interfaces or BonesDefMod methods. You don’t need bothю Usually, one thing is enough.

BonesDef methods work only if the Modifier Panel is opened on the Skin modifier. My goal always was to do skin operations without modifier panel and node selection. that’s why i use ISkin interfaces

ISkin interfaces don’t provide all methods which BonesDef can do. But there is nothing what ISkin can but BonesDef can not.

Did i answer your question?

PS.
BonesDef methods usually expect UI update and redraw, and send notification messages for it, including cases when it’s not necessary.

So it seems ISkin is better, but as I said how we can implement functions like removebone with ISkin? Any library or sample in SDK?

the same way as they do it in BonesDef. The code is there… the only problem is do update of BonesDef local data after that.

I’m just trying to do it with ISkin:

#include <BonesDef.h>
#include <modstack.h>
#include <maxscript/macros/define_instantiation_functions.h>

def_visible_primitive(TestFunction, "TestFunction");
Value* TestFunction_cf(Value **arg_list, int count)
{
	int boneCount = 2;

	// Mesh

	Object* mesh_Obj = (Object*)GetCOREInterface()->CreateInstance(GEOMOBJECT_CLASS_ID, PLANE_CLASS_ID);
	IParamBlock2* mesh_ParamBlock = (IParamBlock2*)mesh_Obj->GetReference(0);
	mesh_ParamBlock->SetValue(0, 0, (float)10);
	mesh_ParamBlock->SetValue(1, 0, (float)10);
	INode* mesh_Node = GetCOREInterface()->CreateObjectNode(mesh_Obj);

	// Bones

	Tab<INode*> bones; bones.SetCount(boneCount);
	for (size_t i = 0; i < boneCount; i++)
	{
		Object* object = (Object*)GetCOREInterface()->CreateInstance(GEOMOBJECT_CLASS_ID, Class_ID(SPHERE_CLASS_ID, 0));
		IParamBlock2* paramBlock = (IParamBlock2*)object->GetReference(0);
		paramBlock->SetValue(SPHERE_RADIUS, 0, (float)5);
		paramBlock->SetValue(SPHERE_SEGS, 0, 6);
		INode* node = GetCOREInterface()->CreateObjectNode(object);
		bones[i] = node;
	}

	// Skin Modifier

	Modifier *skinModifier = (Modifier*)CreateInstance(OSM_CLASS_ID, SKIN_CLASSID);
	IDerivedObject* derivedObject = CreateDerivedObject(mesh_Obj);
	mesh_Node->SetObjectRef(derivedObject);
	derivedObject->SetAFlag(A_LOCK_TARGET);
	derivedObject->AddModifier(skinModifier);
	derivedObject->ClearAFlag(A_LOCK_TARGET);

	// Add Bones

	ISkinImportData* iSkinImportData = (ISkinImportData*)skinModifier->GetInterface(I_SKINIMPORTDATA);
	for (size_t i = 0; i < boneCount; i++)
	{
		iSkinImportData->AddBoneEx(bones[i], i - 1 == boneCount);
	}

	// Replace Weights

	ISkin* iSkin = static_cast<ISkin*>(skinModifier->GetInterface(I_SKIN));
	ISkinContextData* iSkinContextData = iSkin->GetContextInterface(mesh_Node);
	//int vertexCount = iSkinContextData->GetNumPoints();

	Tab<float>weights; weights.SetCount(boneCount);
	weights[0] = 0.1f;
	weights[1] = 0.9f;
	iSkinImportData->AddWeights(mesh_Node, 1, bones, weights);

	return &ok;
}
`indent preformatted text by 4 spaces`

But It doesn’t change any vertex data at all. Also if I uncomment the line:
//int vertexCount = iSkinContextData->GetNumPoints();
I will get several errors.

I just realized that the problem is not from the skin data, When I apply the function to the existing modifier in the scene, its work:

#include <BonesDef.h>
#include <modstack.h>
#include <maxscript/macros/define_instantiation_functions.h>

def_visible_primitive(TestFunction, "TestFunction");
Value* TestFunction_cf(Value **arg_list, int count)
{
	INode* skinNode = arg_list[0]->to_node();
	Modifier* modifier = arg_list[1]->to_modifier();
	ISkin* iSkin = (ISkin*)modifier->GetInterface(I_SKIN);
	BonesDefMod* bonesDefMod = (BonesDefMod*)iSkin;
	BoneModData *boneModData = bonesDefMod->GetBMD(skinNode);
	boneModData->GetNumPoints();

	return &ok;
}

Do I need to update something after object creation?

you do realize that ^^^ is nonsense to anyone else, you may as well post maxscript that uses custom functions great if you want to have a conversation with yourself

Sorry, I don’t undrstand what are you talking about, what is ^^^ ?