I’m a big fan of try/catch in these sorts of cases. Since a classof (light target node) == geometry as well.
I just throw a try/catch
try(getpolycount(Sel[i]))catch()
MarcoBrunetta: the unused varibles are for future use and will of course be made local as advised. Also I didn’t know about the function being global sorry the maxscript help said something about placing your functions in beginning but it makes sense since the function isn’t needed outside the rollout thank you. any other advice on how to make scripts generally more optimized not included in the “how to make it faster” page of the help? Also, is there a way to tell how optimized my script is(perhaps something that returns how much memory its using?) because in basic I print the fps to the screen and tried to optimize from there albeit very basically(pun intended)
EEK: can you explain the try, catch, and throw expression? The help files explanation of these is vague for me because I’m not familiar with exception handling since my is in basic. Also if I were to implement your for loop where would I put that? I seem to have a hard time figuring where things go in a script:argh:
Try, catch and throw to me are essentially break points. The code or function etc, will ‘try’ to execute that piece of code and if it finds an error it’ll either catch it and/or throw it depending on your code. Basically if it breaks you can use the catch ( messageBox “error”) to return the problem, reset values etc. And you can use error to throw an error string.
I hardly use them as it can eat memory, for example resently i had a script that i was doing error check with and used the try/catch – it jumped to 1,700 megs usage in a few seconds ( and crashed with no warning on any click afterwards) With correct formatting and putting in the work without the try/catch it hardly jumped 3 or so megs. Try and catch should be used sparingly.
Q. Also if I were to implement your for loop where would I put that? I seem to have a hard time figuring where things go in a script?
A.
try(destroyDialog myTest) catch(false)
rollout myTest "MyTest"
(
local faceCount = 0
local vertCount = 0
button getCount "Get Count"
on getCount pressed do
(
faceCount = 0
vertCount = 0
for i = 1 to selection.count do
(
if (superClassOf selection[i]) == geometryClass do
(
faceCount += (getPolygonCount selection[i])[1]
vertCount += (getPolygonCount selection[i])[2]
)
)
messagebox (faceCount as string + " Faces & " + vertCount as string + " Verts in current selection" )
)
)
createDialog myTest
I tried putting your for loop and if statement as my function but it always returns as 0.
fn calcPolySel =
(
local polyCountSel = 0
for o=1 to selection.count do
(
if (superClassOf selection[o]) == geometryClass do
(
polyCountSel += (selection[o])[1]
)
)
polyCountSel as string
)
Im guessing its because the condition for the if statement isn’t being met. But i do have objects selected and they are meshes. Also the function is being executed on button pressed.
you forgot to use getPolygonCount to get the number of polies on the object. Right now you’re not actually getting the polygon count for the object.
In fact… the code you have ‘as is’ should throw an error:
-- Incompatible types: 0, and SubAnim:Visibility
woo oops thank you. not sure how i missed that one.:shrug::surprised