[Closed] Runtime error: Bitmap Creation failure

whenever you encounter problems like that, try using the “print” function to print out your variable(s) to see what’s going on there.

My guess is that for the images you’ve picked, dividing width by height ends up with a value of 0. You might wonder why that is, but essentially… presume you’ve picked a picture that’s 512×1024.

512 / 1024 = 0.5, right? Except to maxscript – it’s not. ‘512’ and ‘1024’ are both integers, so it will perform integer math on it… the result thus being zero.

If, on the other hand, you calculate ‘512.0 / 1024.0’, then maxscript performs floating point math, and the result -is- 0.5 .

So in your code, change as follows:

-- old
-- New_Image_Width = (rrh_preview.width / rrh_preview.height) * New_Image_Height

-- new
New_Image_Width = (rrh_preview.width as float / rrh_preview.height) * New_Image_Height

You might wonder why I’m only casting (as it’s called) one of those to a float value. The reason is that if any of the bits in a calculation that MaxScript performs is a float value, it will perform the other bits in float as well. You do have to take care to remember the order of mathematical operations and such (or use parentheses) or, to play it safe, cast them all to float where appropriate.

–

The above is just a hunch, though – no max in front of met at the moment

Hey thanks. I’m learning a lot from your responses.

Before I had the chance to view your reply I did manage to get the formula to work with maxscript by changing the order around a bit.

-- old
-- New_Image_Width = (rrh_preview.width / rrh_preview.height) * New_Image_Height
 
-- new
New_Image_Width = (rrh_preview.width * rrh_rollout.height) / (rrh_preview.height)

I’m not sure exactly what the difference is but these are the numbers I get using the different formulas on paper and using the print command. I’m not sure which is the most accucate. does max inturpret image sizes with decimals properly?

Window size = 800×646
Image size = 800×900, ratio = 0.8888888

Using old formula
Resized Image(using calc) = 574.22216 x 646, ratio = 0.8888887
Script With Print Command = 0x646
Resized Image(w/float) = 574.222 x 646, ratio = 0.8888885

Using New forumala
Resized Image(using calc) = 574.22222 x 646, ratio = 0.8888888
Script With Print Command = 574 x 646, ratio = 0.8885448
Resized Image(w/float) = 574.222 x 646, ratio = 0.8888885

All the numbers are close but slightly different. I’m thinking this is just the number of decimal places the max script listener and my calculator displays… I think?

The one that seems the most accurate on paper is the one using the new formula.

I hope my math was right lol

unless your preview area is as large as the rollout, that second line seems iffy

The very slight difference in theoretical and practical aspects is from there not existing such a thing as 0.222 pixels

You essentially just want to scale the input image based on its aspect ratio and the aspect ratio of your target preview window (as well as whether or not you’d want to scale up any images that are smaller than the preview window, etc.).

I.e. if the input bitmap is in a portrait layout – and let’s assume the preview area is square – then the preview bitmap’s height should be equal to the preview area’s height, and the width scaled accordingly – and vice-versa for landscape images.

here’s a little ‘preview window’ sort of script that might be of use… I don’t recall what issues it has – if any – wrote it a good while ago to play with pasteBitmap (3ds Max 2008 / AVG).

rollout previewRollout "preview" width:216 height:336 (
	bitmap bmp_preview "" pos:[7,8] width:200 height:200
	button btn_load "browse..." pos:[8,208] width:200 height:16
	spinner spn_width "width" pos:[16,240] width:72 height:16 range:[8,200,200] type:#integer
	spinner spn_height "height" pos:[136,240] width:72 height:16 range:[8,200,200] type:#integer
	colorPicker cp_backgroundcol "backgroundcolor" pos:[80,264] width:128 height:16 color:(color 160 160 160)
	checkbox chk_scalesmaller "scale smaller" pos:[8,288] width:110 height:16
	checkbox chk_filter "high quality scaling" pos:[8,312] width:112 height:16

	local pickedBmp
	
	local noBitmapBmp
	
	fn noBitmap w h = (
		if (noBitmapBmp == undefined) then (
			noBitmapBmp = bitmap w h
			for y = 1 to h do (
				for x = 1 to w do (
					if (x == y) then (
						setPixels noBitmapBmp [x-1,y-1] #((color 255 255 255))
						setPixels noBitmapBmp [w-x,y-1] #((color 255 255 255))
					)
				)
			)
		)
		noBitmapBmp
	)
	
	fn createThumb inBmp res:[128,128] scalesmaller:false backgroundCol:(color 192 192 192) filter:false = (
		local outBmp = bitmap res.x res.y color:backgroundCol
		local scaledBmp
		if ((inBmp.width <= res.x) AND (inBmp.height <= res.y) AND (not scalesmaller)) then ( scaledBmp = inBmp )
		else (
			local inAspect = (inBmp.width as float / inBmp.height)
			local outAspect = res.x / res.y
			if (inAspect >= outAspect) then ( scaledBmp = bitmap res.x ((res.x as float / inBmp.width) * inBmp.height) )
			else ( scaledBmp = bitmap ((res.y as float / inBmp.height) * inBmp.width) res.y )

			if (filter AND (doesFileExist inBmp.filename)) then (
				local bmpTexture = bitmapTexture filename:inBmp.filename filtering:1
				rendermap bmpTexture into:scaledBmp filter:true
			)
			else (
				copy inBmp scaledBmp
			)
		)
		pasteBitmap scaledBmp outBmp [0,0] [((res.x / 2.0) - (scaledBmp.width / 2.0)),((res.y / 2.0) - (scaledBmp.height / 2.0))]
		outBmp
	)
	
	fn genThumb = (
		if (pickedBmp != undefined) then (
			bmp_preview.bitmap = createThumb pickedBmp res:[spn_width.value,spn_height.value] scalesmaller:chk_scalesmaller.checked backgroundcol:cp_backgroundcol.color filter:chk_filter.checked
		)
	)
	on btn_load pressed do (
		local loadBmp = selectBitmap()
		if (loadBmp != undefined) then (
			pickedBmp = loadBmp
			genThumb()
		)
		else (
			bmp_preview.bitmap = noBitmap spn_width.value spn_height.value
		)
	)

	on spn_width changed val do ( genThumb() )
	on spn_height changed val do ( genThumb() )
	on cp_backgroundcol changed col do ( genThumb() )
	on chk_scalesmaller changed state do ( genThumb() )
	on chk_filter changed state do ( genThumb() )

	on previewRollout open do (
		bmp_preview.bitmap = noBitmap spn_width.value spn_height.value
	)
)
createDialog previewRollout

Hahahahaha. Very nice.

I just change the size of the imgbox.

 
fn resizebitmapdims inputbitmap maxdims =
(
 local outputaspect = (maxdims.x/(maxdims.y as float))
local bwidth = inputbitmap.width as float
local bheight = inputbitmap.height as float
 local baspect = (bwidth/bheight) as float
 local nwidth = nheight = 0

 if baspect >= outputaspect then
 (
  nwidth = maxdims[1] as integer
  nheight = (maxdims[1] / baspect) as integer
 )
 else
 (
  nwidth = (maxdims[2] * baspect) as integer
  nheight = (maxdims[2]) as integer
 )
 return [nwidth, nheight]
)

This just returns a point2 value to give to your imgbox.

Richard do you remember what sort of performance hit it took to rescale a thumbnail? Was it really speedy? I could use a nice fast thumbnail generator.

it’s a fair bit slower when you use the ‘high quality’ (bitmap texture with filtering) option… wouldn’t recommend it unless you’re only displaying the preview bitmap incidentally anyway. E.g. if you’re using spinners for something, you might do a non-filtered one (using whatever method – copy, or adjusting an imgtag’s dimensions, etc.) in ‘on <spinner> changed’, and do a filtered on in ‘on <spinner> buttonup’ (I think it’s buttonup?)

The script you posted won’t work in max9 I get this error “– Type error: Call needs function or class, got: undeefined” and it ponts to this line. “pasteBitmap scaledBmp outBmp [0,0] [((res.x / 2.0) – (scaledBmp.width / 2.0)),((res.y / 2.0) – (scaledBmp.height / 2.0))]”

Yea I fixed the code now. The only thing left to do is get the script to only copy/change the new bitmap size if the new bitmap is larger or smaller then the previous bitmap. Right now I can’t scroll through the images in the preview window without it constantly updating and flickering the screen. In other words its very slow.

if (rrh_rollout.width / (rrh_rollout.height as float -46)) < (rrh_preview.width / rrh_preview.height as float) then -- If image is larger then window then resize image and keep the aspect ratio the same.
 
(
if (rrh_preview.width > rrh_rollout.width as float) or (rrh_preview.height > (rrh_rollout.height as float - 46)) then
(
New_Image_Width = rrh_rollout.width
New_Image_Height = (rrh_preview.height * New_Image_Width) / (rrh_preview.width as float) -- The "as float" command keeps the decimals or else maxscript would return a "0" and crash.
 
print New_Image_Width
print New_Image_Height
 
Oversize_image = bitmap (New_Image_Width) (New_Image_Height) 
current_image = openbitmap get_image_files[image_index]
copy current_image Oversize_image
rrh_preview.bitmap = Oversize_image
rrh_preview.width = Oversize_image.width
rrh_preview.height = Oversize_image.height
rrh_preview.pos = [(rrh_rollout.width / 2) - (rrh_preview.width / 2), ( rrh_rollout.height / 2) - (46 / 2) - (rrh_preview.height / 2)]
)
 
 
 
)
else
 
(
if (rrh_preview.width > rrh_rollout.width as float) or (rrh_preview.height > (rrh_rollout.height as float - 46)) then
(
New_Image_Height = (rrh_rollout.height - 46) -- the -46 subtracts the toolbar height. I also did this on the line below.
New_Image_Width = (rrh_preview.width * (rrh_rollout.height - 46)) / (rrh_preview.height as float) -- The "as float" command keeps the decimals or else maxscript would return a "0" and crash.
 
print New_Image_Width
print New_Image_Height
Oversize_image = bitmap (New_Image_Width) (New_Image_Height)
current_image = openbitmap get_image_files[image_index]
copy current_image Oversize_image
rrh_preview.bitmap = Oversize_image
rrh_preview.width = Oversize_image.width
rrh_preview.height = Oversize_image.height
rrh_preview.pos = [(rrh_rollout.width / 2) - (rrh_preview.width / 2), ( rrh_rollout.height / 2) - (46 / 2) - (rrh_preview.height / 2)] 
)
)
 

yeah, as I mentioned “wrote it a good while ago to play with pasteBitmap (3ds Max 2008 / AVG)”; no 3ds Max 9 for that. Essentially it just pastes the bitmap into another bitmap… some getPixels/setPixels stuff does the same job, just slower