[Closed] C++ Skin

This is my code that is a function to remove unused bones:

#include <maxscript/maxscript.h>
#include <maxscript/foundation/3dmath.h>
#include <maxscript/macros/define_instantiation_functions.h>
#include "iskin.h"
#include "bonesdef.h"
def_visible_primitive(RemoveUnusedBones, "RemoveUnusedBones");
Value* RemoveUnusedBones_cf(Value **arg_list, int count)
{
   INode* node = arg_list[0]->to_node();
   Modifier* modifier = arg_list[1]->to_modifier();
   ISkin* skin = (ISkin *)modifier->GetInterface(I_SKIN);
   BonesDefMod* bkin = (BonesDefMod*)skin;
   ISkinContextData *skinData = skin->GetContextInterface(node);
   BitArray usedbones = BitArray(skin->GetNumBones());
   for (int i = 0; i < skinData->GetNumPoints(); i++)
   {
      for (int j = 0; j < skinData->GetNumAssignedBones(i); j++)
      {
         int boneIndex = skinData->GetAssignedBone(i, j);
         float boneWeight = skinData->GetBoneWeight(i, j);
         if (boneWeight > 0) usedbones.Set(boneIndex);
      }
   }
   for (int i = usedbones.GetSize(); i < 0; i--)
   {
      if (usedbones[i] == 0) bkin->RemoveBone(i);
   }
   return new BitArrayValue(usedbones);
}

This should work, right? But I got several errors:

Do you see any error in the code? or you think errors comes from build environment and project setting? Note that when I open bonesdef project, I got .Net version error.

So my questions are:
1 – Where the MS function “skinOps” in the SDK? Is it bonesdef? I mean Skinops is created by using bonesdef.h?
2 – How I can “pared back” the bonesdef.h?
3 – Again, do you think the code itself works correctly?
4 – I think I installed every SDK requirements, but I got this error when I want to open bonesdef.h:

F:\Software\3dsMax\SDK\3ds Max 2018 SDK\maxsdk\samples\render\NotificationSystem\NotificationSystem.vcxproj : error : A numeric comparison was attempted on “$(_TargetFrameworkVersionWithoutV)” that evaluates to “V4.6” instead of a number, in condition “’$(ImplicitlyExpandNETStandardFacades)’ == ‘’ AND ‘$(_TargetFrameworkVersionWithoutV)’ >= ‘4.6.1’”. C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Microsoft\Microsoft.NET.Build.Extensions\Microsoft.NET.Build.Extensions.NETFramework.targets

I removed all .Net versions from my computer, then I installed several versions until 4.6 , but I still get the error. my build information is:
Windows 7
Max 2018
VS 2017
Latest Windows 10 SDk installed

After struggling with SDK requirements and installing VS 2015, I just added my following code to the “bonesdef” project and now I can compiled it, I replaced MaxFolder/Stdplugs/bonesdef.dlm with my code and now my function works perfectly in max.

#include "mods.h"
#include "bonesdef.h"
#include <maxscript/macros/define_instantiation_functions.h>
#include "modstack.h"

Modifier* FindSkinModifier(INode* nodePtr)
{
    Object* ObjectPtr = nodePtr->GetObjectRef();
    if (!ObjectPtr) return NULL;
    while (ObjectPtr && ObjectPtr->SuperClassID() == GEN_DERIVOB_CLASS_ID)
    {
        IDerivedObject *DerivedObjectPtr = (IDerivedObject *)(ObjectPtr);
        int ModStackIndex = 0;
        while (ModStackIndex < DerivedObjectPtr->NumModifiers())
        {
            Modifier* ModifierPtr = DerivedObjectPtr->GetModifier(ModStackIndex);
            if (ModifierPtr->ClassID() == Class_ID(SKIN_CLASSID)) 
            {
                return ModifierPtr;
            }
            ModStackIndex++;
        }
        ObjectPtr = DerivedObjectPtr->GetObjRef();
    }
    return NULL;
}

void RecursiveRemoveUnusedBones(INode* node)
{
    Modifier* skin = FindSkinModifier(node);
    if (skin)
    {
        ISkin* iskin = (ISkin *)skin->GetInterface(I_SKIN);
        BonesDefMod* bmod = (BonesDefMod*)iskin;
        ISkinContextData *skinData = iskin->GetContextInterface(node);
        BitArray usedbones = BitArray(iskin->GetNumBones());
        for (int i = 0; i < skinData->GetNumPoints(); i++)
        {
            for (int j = 0; j < skinData->GetNumAssignedBones(i); j++)
            {
                int boneIndex = skinData->GetAssignedBone(i, j);
                float boneWeight = skinData->GetBoneWeight(i, j);
                if (boneWeight > 0) usedbones.Set(boneIndex);
            }
        }
        for (int i = usedbones.GetSize(); i >= 0; i--)
        {
            if (usedbones[i] != 1) bmod->RemoveBone(i);
        }
    }

    for (int i = 0; i < node->NumberOfChildren(); ++i)
    {
        RecursiveRemoveUnusedBones(node->GetChildNode(i));
    }
}

def_visible_primitive(RemoveUnusedBones, "RemoveUnusedBones");
Value* RemoveUnusedBones_cf(Value **arg_list, int count)
{
    RecursiveRemoveUnusedBones(GetCOREInterface()->GetRootNode());
    return &ok;
}

Now my question is how I can make the independent version?

I want to use c++ because of speed. do you think calling MS in C++ is not efficient? I saw many examples in SDK that used macro. Apart from the checking the macro, side problem is that this function doesn’t do the job in MaxScript:

#include <maxscript/maxscript.h>
#include <maxscript/foundation/3dmath.h>
#include <maxscript/macros/define_instantiation_functions.h>
#include "iskin.h"
#include "modstack.h"
#include "macrorec.h"
#include "maxscript/util/listener.h"

def_visible_primitive(RemoveUnusedBones, "RemoveUnusedBones");
Value* RemoveUnusedBones_cf(Value **arg_list, int count)
{
    INode* node = arg_list[0]->to_node();
    Modifier* modifier = arg_list[1]->to_modifier();
    
    Interface* core = GetCOREInterface();
    TimeValue t = core->GetTime();
    Object *obj = node->GetObjectRef()->Eval(t).obj;
    IDerivedObject *drivedObj = CreateDerivedObject(obj);
    ISkin* skin = (ISkin *)modifier->GetInterface(I_SKIN);
    ISkinContextData *skinData = skin->GetContextInterface(node);
    BitArray usedbones = BitArray(skin->GetNumBones());

    for (int i = 0; i < skinData->GetNumPoints(); i++)
    {
        for (int j = 0; j < skinData->GetNumAssignedBones(i); j++)
        {
            int boneIndex = skinData->GetAssignedBone(i, j);
            float boneWeight = skinData->GetBoneWeight(i, j);
            if (boneWeight > 0) usedbones.Set(boneIndex);
        }
    }
    for (int i = usedbones.GetSize(); i > 0; i--)
    {
        //if (usedbones[i] != 1)
        //{
            macroRecorder->FunctionCall(_T("skinOps.selectBone"), 2, 0, mr_reftarg, skin, mr_int, i + 1);
            macroRecorder->FunctionCall(_T("skinOps.removeBone"), 2, 0, mr_reftarg, skin, mr_int, i + 1);
        //}
    }

    drivedObj->NotifyDependents(FOREVER, GEOM_CHANNEL, REFMSG_CHANGE);
    core->RedrawViews(t);

    return &ok;
}

Would you please explain more? I just want to expose a function to the MaxScript, I don’t want to create any new class (modifier?), my thought was we don’t need to generate ClassID for the function publishing pipeline. actually my question was how we can include-use bonesdef methods out of the bonesdef project.

The only problem is how to include skin functions in my project.

This is ricky, isn’t it? Maybe user wants to install different skin tools from different developer at the same time.

I finally figure it out how to create a standalone project and include BonesDef functions! (I guess you know this already!, but I just want to confirm you ) We should follow this steps:
1 – Include BonesDef.h.
2 – Create a static library of BonesDef (.lib).
3 – Add that library to the Project Setting/Additional Library.
4 – Copy dependency list from BonesDef project/Additional Dependency and append it to our project.
5 – Also append “BonesDef.lib” to the list.